]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Update TransactionXmin when MyProc->xmin is updated
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Sat, 21 Dec 2024 21:42:39 +0000 (23:42 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Sat, 21 Dec 2024 21:42:59 +0000 (23:42 +0200)
commit41eafbb494c9578fa04ffa529a10e4cfd6942421
tree6f65378298293532abcfff758e46f07311151e6f
parent23c743b645a546f7ec7aae0a3d7201328d6994b3
Update TransactionXmin when MyProc->xmin is updated

GetSnapshotData() set TransactionXmin = MyProc->xmin, but when
SnapshotResetXmin() advanced MyProc->xmin, it did not advance
TransactionXmin correspondingly. That meant that TransactionXmin could
be older than MyProc->xmin, and XIDs between than TransactionXmin and
the real MyProc->xmin could be vacuumed away. One known consequence is
in pg_subtrans lookups: we might try to look up the status of an XID
that was already truncated away.

Back-patch to all supported versions.

Reviewed-by: Andres Freund
Discussion: https://www.postgresql.org/message-id/d27a046d-a1e4-47d1-a95c-fbabe41debb4@iki.fi
src/backend/utils/time/snapmgr.c