]> git.ipfire.org Git - thirdparty/linux.git/commit
sched_ext: bpf_iter_scx_dsq_new() should always initialize iterator
authorTejun Heo <tj@kernel.org>
Mon, 5 May 2025 21:30:39 +0000 (11:30 -1000)
committerTejun Heo <tj@kernel.org>
Wed, 7 May 2025 16:24:07 +0000 (06:24 -1000)
commit428dc9fc0873989d73918d4a9cc22745b7bbc799
tree8102669845543340f2340f839978639d572069fb
parente38be1c7647c8c78304ce6d931b3b654e27948b3
sched_ext: bpf_iter_scx_dsq_new() should always initialize iterator

BPF programs may call next() and destroy() on BPF iterators even after new()
returns an error value (e.g. bpf_for_each() macro ignores error returns from
new()). bpf_iter_scx_dsq_new() could leave the iterator in an uninitialized
state after an error return causing bpf_iter_scx_dsq_next() to dereference
garbage data. Make bpf_iter_scx_dsq_new() always clear $kit->dsq so that
next() and destroy() become noops.

Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 650ba21b131e ("sched_ext: Implement DSQ iterator")
Cc: stable@vger.kernel.org # v6.12+
Acked-by: Andrea Righi <arighi@nvidia.com>
kernel/sched/ext.c