]> git.ipfire.org Git - thirdparty/nftables.git/commit
libnftables: Simplify nft_run_cmd_from_buffer footprint
authorPhil Sutter <phil@nwl.cc>
Mon, 18 Jun 2018 08:11:46 +0000 (10:11 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 18 Jun 2018 09:18:02 +0000 (11:18 +0200)
commit4677971a01dc4d92087dab139428cf4eaa189536
tree6f287f244a935755cf004f737b2b850694820871
parent5ca7ad252366865225d5c59d297e71215b68f027
libnftables: Simplify nft_run_cmd_from_buffer footprint

With libnftables documentation being upstream and one confirmed external
user (nftlb), time to break the API!

First of all, the command buffer passed to nft_run_cmd_from_buffer may
(and should) be const. One should consider it a bug if that function
ever changed it's content.

On the other hand, there is no point in passing the buffer's length as
separate argument: NULL bytes are not expected to occur in the input, so
it is safe to rely upon strlen(). Also, the actual parsers don't require
a buffer length passed to them, either. The only use-case for it is when
reallocating the buffer to append a final newline character, there
strlen() is perfectly sufficient.

Suggested-by: Harald Welte <laforge@gnumonks.org>
Cc: Laura Garcia Liebana <nevola@gmail.com>
Cc: Eric Leblond <eric@regit.org>
Cc: Arturo Borrero Gonzalez <arturo@netfilter.org>
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
doc/libnftables.adoc
include/json.h
include/nftables/libnftables.h
py/nftables.py
src/Makefile.am
src/cli.c
src/libnftables.c
src/main.c
src/parser_json.c