]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
selftests: net: lib: fix shift count out of range
authorHangbin Liu <liuhangbin@gmail.com>
Wed, 9 Jul 2025 09:12:44 +0000 (09:12 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Jul 2025 01:11:52 +0000 (18:11 -0700)
commit47c84997c686b4d43b225521b732492552b84758
tree11a8712c51de999e300a1b53cf29457fe2b6564f
parentce913b2292e9bdf2661af6e584ddfb4ed5978893
selftests: net: lib: fix shift count out of range

I got the following warning when writing other tests:

  + handle_test_result_pass 'bond 802.3ad' '(lacp_active off)'
  + local 'test_name=bond 802.3ad'
  + shift
  + local 'opt_str=(lacp_active off)'
  + shift
  + log_test_result 'bond 802.3ad' '(lacp_active off)' ' OK '
  + local 'test_name=bond 802.3ad'
  + shift
  + local 'opt_str=(lacp_active off)'
  + shift
  + local 'result= OK '
  + shift
  + local retmsg=
  + shift
  /net/tools/testing/selftests/net/forwarding/../lib.sh: line 315: shift: shift count out of range

This happens because an extra shift is executed even after all arguments
have been consumed. Remove the last shift in log_test_result() to avoid
this warning.

Fixes: a923af1ceee7 ("selftests: forwarding: Convert log_test() to recognize RET values")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://patch.msgid.link/20250709091244.88395-1-liuhangbin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/lib.sh