]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Harden create_temp_filename() (version 2)
authorDavid Sommerseth <dazo@users.sourceforge.net>
Fri, 16 Apr 2010 20:02:36 +0000 (22:02 +0200)
committerDavid Sommerseth <dazo@users.sourceforge.net>
Thu, 21 Oct 2010 09:37:03 +0000 (11:37 +0200)
commit4e1cc5f6dda22e9ff121d3753066775c25448bcc
treed58ab37fedc0795d2b4c75b4f500a66e1aa415e6
parent41104b4e23aaa17257cadb7f6c4ba1325c025b46
Harden create_temp_filename() (version 2)

By hardening the create_temp_filename() function to check if the generated
filename exists and to create the temp file with only S_IRUSR|S_IWUSR bit
files set before calling the script, it should become even more difficult to
exploit such a scenario.

After a discussion on the mailing list, Fabian Knittel provided an enhanced
version of the inital patch which is added to this patch.

This patch also renames create_temp_filename() to create_temp_file(), as this
patch also creates the temporary file.  The function returns the filename of the
created file, or NULL on error.

Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>
Signed-off-by: Fabian Knittel <fabian.knittel@avona.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
misc.c
misc.h