]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't throw an error if a queued AFTER trigger no longer exists.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 20 Jun 2024 18:21:36 +0000 (14:21 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 20 Jun 2024 18:21:36 +0000 (14:21 -0400)
commit4f196667627055ce7c6b3e8d3e9a4f5f6a906b86
tree3367d8b04447a732259c3eea8ebda06616ad57df
parent6143c9c03f7f43a1a16e2587c6f12aa7d81558c8
Don't throw an error if a queued AFTER trigger no longer exists.

afterTriggerInvokeEvents and AfterTriggerExecute have always
treated it as an error if the trigger OID mentioned in a queued
after-trigger event can't be found.  However, that fails to
account for the edge case where the trigger's been dropped in
the current transaction since queueing the event.  There seems
no very good reason to disallow that case, so instead silently
do nothing if the trigger OID can't be found.

This does give up a little bit of bug-detection ability, but I don't
recall that these error messages have ever actually revealed a bug,
so it seems mostly theoretical.  Alternatives such as marking
pending events DONE at the time of dropping a trigger would be
complicated and perhaps introduce bugs of their own.

Per bug #18517 from Alexander Lakhin.  Back-patch to all
supported branches.

Discussion: https://postgr.es/m/18517-af2d19882240902c@postgresql.org
src/backend/commands/trigger.c
src/test/regress/expected/triggers.out
src/test/regress/sql/triggers.sql