]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Remove fls(), use pg_leftmost_one_pos32() instead.
authorThomas Munro <tmunro@postgresql.org>
Thu, 21 Jul 2022 21:41:12 +0000 (09:41 +1200)
committerThomas Munro <tmunro@postgresql.org>
Thu, 21 Jul 2022 22:41:50 +0000 (10:41 +1200)
commit4f1f5a7f85cee932c417aef589b27574813a06c9
tree0a9b86ad582917b9ed8c31199f3ae8dca5b9b38c
parent3225399021b62cda66012b17ee60c7bec4733fce
Remove fls(), use pg_leftmost_one_pos32() instead.

Commit 4f658dc8 provided the traditional BSD fls() function in
src/port/fls.c so it could be used in several places.  Later we added a
bunch of similar facilities in pg_bitutils.h, based on compiler
builtins that map to hardware instructions.  It's a bit confusing to
have both 1-based and 0-based variants of this operation in use in
different parts of the tree, and neither is blessed by a standard.
Let's drop fls.c and the configure probe, and reuse the newer code.

Reviewed-by: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CA%2BhUKG%2B7dSX1XF8yFGmYk-%3D48dbjH2kmzZj16XvhbrWP-9BzRg%40mail.gmail.com
configure
configure.ac
src/backend/access/hash/hashutil.c
src/backend/optimizer/path/allpaths.c
src/backend/optimizer/prep/prepunion.c
src/backend/utils/mmgr/dsa.c
src/include/pg_config.h.in
src/include/port.h
src/port/fls.c [deleted file]
src/tools/msvc/Mkvcbuild.pm
src/tools/msvc/Solution.pm