]> git.ipfire.org Git - thirdparty/vim.git/commit
patch 9.0.2090: complete_info() skips entries with 'noselect' v9.0.2090
authorChristian Brabandt <cb@256bit.org>
Sat, 4 Nov 2023 08:58:14 +0000 (09:58 +0100)
committerChristian Brabandt <cb@256bit.org>
Sat, 4 Nov 2023 08:58:14 +0000 (09:58 +0100)
commit57f9ce1a0977da13e5923214086795ffa2d28ce1
treed0bae6e2534822005e208ba858cb6b054f2c47a2
parentb23c1fc596501a8dfc0355ed8084dcbf018f7907
patch 9.0.2090: complete_info() skips entries with 'noselect'

Problem:  complete_info() skips entries with 'noselect'
Solution: Check, if first entry is at original text state

Unfortunately, Commit daef8c74375141974d61b85199b383017644978c
introduced a regression, that when ':set completeopt+=noselect' is set
and no completion item has been selected yet, it did not fill the
complete_info['items'] list.

This happened, because the current match item did not have the
CP_ORIGINAL_TEXT flag set and then the cp->prev pointer did point to the
original flag item, which caused the following while loop to not being
run but being skipped instead.

So when the 'noselect' is set, only start with to the previous selection
item, if the initial completion item has the CP_ORIGINAL_TEXT flag set,
else use the 2nd previous item instead.

fixes: #13451
closes: #13452

Signed-off-by: Christian Brabandt <cb@256bit.org>
src/insexpand.c
src/testdir/test_ins_complete.vim
src/version.c