]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix problem with special case route targets ('remote_host')
authorGert Doering <gert@greenie.muc.de>
Thu, 21 Oct 2010 08:35:29 +0000 (10:35 +0200)
committerDavid Sommerseth <dazo@users.sourceforge.net>
Thu, 21 Oct 2010 18:56:48 +0000 (20:56 +0200)
commit59afc4a5f72e22b850cfa2845385172623a38e77
tree1c86fd147e6dee2454952bcea21ef5f9e269c2c9
parentd6b783a8ec505c8e158bd0304c5e195cff5bb8c3
Fix problem with special case route targets ('remote_host')

The init_route() function will leave &netlist untouched for
get_special_addr() routes ("remote_host" being one of them).
netlist is on stack,  contains random garbage, and netlist.len
will not be 0 - thus, random stack data is copied from
netlist.data[] until the route_list is full.

This issue has been reported several places lately:
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=600166
   http://thread.gmane.org/gmane.network.openvpn.devel/4083
   https://forums.openvpn.net/viewtopic.php?f=1&t=7201&p=8168

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: David Sommerseth <dazo@users.sourceforge.net>
Acked-by: James Yonan <james@openvpn.net>
Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>
route.c