]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Revert "drm/prime: Use dma_buf from GEM object instance"
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 15 Jul 2025 15:58:14 +0000 (17:58 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Aug 2025 08:51:26 +0000 (09:51 +0100)
commit5f05d83ce689a8930a70dfa73f879604aef8cc03
tree1a043a9c9d4d71465f237e1cc47dc1dcaf799dde
parent3701da66018e238115c1f21d2d95ab0716ed38d5
Revert "drm/prime: Use dma_buf from GEM object instance"

commit fb4ef4a52b79a22ad382bfe77332642d02aef773 upstream.

This reverts commit f83a9b8c7fd0557b0c50784bfdc1bbe9140c9bf8.

The dma_buf field in struct drm_gem_object is not stable over the
object instance's lifetime. The field becomes NULL when user space
releases the final GEM handle on the buffer object. This resulted
in a NULL-pointer deref.

Workarounds in commit 5307dce878d4 ("drm/gem: Acquire references on
GEM handles for framebuffers") and commit f6bfc9afc751 ("drm/framebuffer:
Acquire internal references on GEM handles") only solved the problem
partially. They especially don't work for buffer objects without a DRM
framebuffer associated.

Hence, this revert to going back to using .import_attach->dmabuf.

v3:
- cc stable

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch>
Acked-by: Christian König <christian.koenig@amd.com>
Acked-by: Zack Rusin <zack.rusin@broadcom.com>
Cc: <stable@vger.kernel.org> # v6.15+
Link: https://lore.kernel.org/r/20250715155934.150656-5-tzimmermann@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/drm_prime.c