]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: fix double free when RNG cold-plug fails
authorLuyao Huang <lhuang@redhat.com>
Tue, 12 May 2015 13:55:05 +0000 (21:55 +0800)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 12 May 2015 15:09:14 +0000 (17:09 +0200)
commit5f6fe84d5731a45fa3fe08701f0d553818dd3e12
tree3415c0b58136d78b15c4678fc1f3b3b7a05b70fc
parentecc997fd43b1b1987dadb45fb0ef987d56638476
qemu: fix double free when RNG cold-plug fails

https://bugzilla.redhat.com/show_bug.cgi?id=1220809

When cold-plugging an RNG device but something fails in
qemuDomainAssignAddresses, we will double free the RNG device.
Once a device is plugged into the domain, we should set the
device pointer to NULL to fix this issue.

...
5  0x00007fb7d180ac8a in virFree at util/viralloc.c:582
6  0x00007fb7d1895cdd in virDomainRNGDefFree at conf/domain_conf.c:19786
7  0x00007fb7d1895d99 in virDomainDeviceDefFree at conf/domain_conf.c:2022
8  0x00007fb7b92b8baf in qemuDomainAttachDeviceFlags at qemu/qemu_driver.c:8785
9  0x00007fb7d190c5d7 in virDomainAttachDeviceFlags at libvirt-domain.c:8488
10 0x00007fb7d23af9d2 in remoteDispatchDomainAttachDeviceFlags at remote_dispatch.h:2842
...

Signed-off-by: Luyao Huang <lhuang@redhat.com>
src/qemu/qemu_driver.c