]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
metadump: bounds check btree block regions being zeroed
authorDave Chinner <dchinner@redhat.com>
Tue, 9 Feb 2016 00:09:27 +0000 (11:09 +1100)
committerDave Chinner <david@fromorbit.com>
Tue, 9 Feb 2016 00:09:27 +0000 (11:09 +1100)
commit6058426f0315e917e0334c210bf8fc795947e26b
tree86e36c3c4752d0fde8d3f16d0c7dbcc062e1b972
parenta7302f830eb7dff46b642f4bcb64bc9a0208a08e
metadump: bounds check btree block regions being zeroed

Arkadiusz Miskiewicz reported that metadump was crashing on one of
his corrupted filesystems, and the trace indicated that it was
zeroing unused regions in inode btree blocks when it failed. The
btree block had a corrupt nrecs field, which was resulting in an out
of bounds memset() occurring.  Ensure that the region being
generated for zeroing is within bounds before executing the zeroing.

Reported-by: Arkadiusz Miskiewicz <arekm@maven.pl>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
db/metadump.c