]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
pwm: imx-tpm: Reset counter if CMOD is 0
authorLaurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Mon, 28 Jul 2025 19:41:44 +0000 (15:41 -0400)
committerUwe Kleine-König <ukleinek@kernel.org>
Tue, 29 Jul 2025 15:51:27 +0000 (17:51 +0200)
commit65c6f742ab14ab1a2679fba72b82dcc0289d96f1
tree2e1c6d9bf4dcc3215b1730da12d16b823d107116
parentf21d136caf8171f94159d975ea4620c164431bd9
pwm: imx-tpm: Reset counter if CMOD is 0

As per the i.MX93 TRM, section 67.3.2.1 "MOD register update", the value
of the TPM counter does NOT get updated when writing MOD.MOD unless
SC.CMOD != 0. Therefore, with the current code, assuming the following
sequence:

1) pwm_disable()
2) pwm_apply_might_sleep() /* period is changed here */
3) pwm_enable()

and assuming only one channel is active, if CNT.COUNT is higher than the
MOD.MOD value written during the pwm_apply_might_sleep() call then, when
re-enabling the PWM during pwm_enable(), the counter will end up resetting
after UINT32_MAX - CNT.COUNT + MOD.MOD cycles instead of MOD.MOD cycles as
normally expected.

Fix this problem by forcing a reset of the TPM counter before MOD.MOD is
written.

Fixes: 738a1cfec2ed ("pwm: Add i.MX TPM PWM driver support")
Cc: stable@vger.kernel.org
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Link: https://lore.kernel.org/r/20250728194144.22884-1-laurentiumihalcea111@gmail.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
drivers/pwm/pwm-imx-tpm.c