]> git.ipfire.org Git - thirdparty/unbound.git/commit
Review comments for the fast reload feature (#1259)
authorYorgos Thessalonikefs <yorgos@nlnetlabs.nl>
Mon, 31 Mar 2025 12:02:02 +0000 (14:02 +0200)
committerGitHub <noreply@github.com>
Mon, 31 Mar 2025 12:02:02 +0000 (14:02 +0200)
commit6b793c71d9482abf81b82a583447d23c6dc62b26
tree55e316115c1dc8a71dd9298fbf2615af28f3a06c
parentbd2d021b9ca0af6516b68fc47ca00b442fe4ea4a
Review comments for the fast reload feature (#1259)

* - fast-reload review, respip set can be null from a view.

* - fast-reload review, typos.

* - fast-reload review, keep clang static analyzer happy.

* - fast-reload review, don't forget to copy tag_actions.

* - fast-reload review, less indentation.

* - fast-reload review, don't leak respip_actions when reloading.

* - fast-reload review, protect NULL pointer dereference in get_mem
  functions.

* - fast-reload review, add fast_reload_most_options.tdir to test most
  options with high verbosity when fast reloading.

* - fast-reload review, don't skip new line on long error printouts.

* - fast-reload review, typo.

* - fast-reload review, use new_z for consistency.

* - fast-reload review, nit for unlock ordering to make eye comparison
  with the lock counterpart easier.

* - fast-reload review, in case of error the sockets are already closed.

* - fast-reload review, identation.

* - fast-reload review, add static keywords.

* - fast-reload review, update unbound-control usage text.

* - fast-reload review, updates to the man page.
19 files changed:
daemon/remote.c
daemon/worker.c
doc/unbound-control.8.in
respip/respip.c
services/authzone.c
services/localzone.c
services/mesh.c
services/view.c
smallapp/unbound-control.c
testdata/fast_reload_fwd.tdir/fast_reload_fwd.pre
testdata/fast_reload_most_options.tdir/auth.nlnetlabs.nl.zone [new file with mode: 0644]
testdata/fast_reload_most_options.tdir/fast_reload_most_options.conf [new file with mode: 0644]
testdata/fast_reload_most_options.tdir/fast_reload_most_options.dsc [new file with mode: 0644]
testdata/fast_reload_most_options.tdir/fast_reload_most_options.post [new file with mode: 0644]
testdata/fast_reload_most_options.tdir/fast_reload_most_options.pre [new file with mode: 0644]
testdata/fast_reload_most_options.tdir/fast_reload_most_options.test [new file with mode: 0644]
testdata/fast_reload_most_options.tdir/rpz.nlnetlabs.nl.zone [new file with mode: 0644]
util/config_file.c
validator/val_anchor.c