]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix pg_dump --clean with partitioned indexes.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 16 Apr 2025 17:31:44 +0000 (13:31 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 16 Apr 2025 17:31:44 +0000 (13:31 -0400)
commit7144cd53821f7ba9008cc9ecb0223ef0dde0ce2f
tree77e26b2e8495141332522eabc56b643723550b37
parent97d671672393683d8f3c43ef0324be2cb80d6276
Fix pg_dump --clean with partitioned indexes.

We'd try to drop the partitions of a partitioned index separately,
which is disallowed by the backend, leading to an error during
restore.  While the error is harmless, it causes problems if you
try to use --single-transaction mode.

Fortunately, there seems no need to do a DROP at all, since the
partition will go away silently when we drop either the parent index
or the partition's table.  So just make the DROP conditional on not
being a partition.

Reported-by: jian he <jian.universality@gmail.com>
Author: jian he <jian.universality@gmail.com>
Reviewed-by: Pavel Stehule <pavel.stehule@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CACJufxF0QSdkjFKF4di-JGWN6CSdQYEAhGPmQJJCdkSZtd=oLg@mail.gmail.com
Backpatch-through: 13
src/bin/pg_dump/pg_dump.c