]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nui: Fix dma_mapping_error() check
authorThomas Fourier <fourier.thomas@gmail.com>
Mon, 30 Jun 2025 08:36:43 +0000 (10:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Jul 2025 16:24:57 +0000 (18:24 +0200)
commit73c38e679ab3ed1f981fdb20a83f4e156c9b16ef
tree528197ed3b209aef2b43ab5c9eea8d9a14cb7e06
parent32bc854b8f3a55472dea538ed95d37ebba91da01
nui: Fix dma_mapping_error() check

[ Upstream commit 561aa0e22b70a5e7246b73d62a824b3aef3fc375 ]

dma_map_XXX() functions return values DMA_MAPPING_ERROR as error values
which is often ~0.  The error value should be tested with
dma_mapping_error().

This patch creates a new function in niu_ops to test if the mapping
failed.  The test is fixed in niu_rbr_add_page(), added in
niu_start_xmit() and the successfully mapped pages are unmaped upon error.

Fixes: ec2deec1f352 ("niu: Fix to check for dma mapping errors.")
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/sun/niu.c
drivers/net/ethernet/sun/niu.h