]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Wake up for latches in CheckpointWriteDelay().
authorThomas Munro <tmunro@postgresql.org>
Wed, 16 Mar 2022 00:37:58 +0000 (13:37 +1300)
committerThomas Munro <tmunro@postgresql.org>
Wed, 16 Mar 2022 00:57:07 +0000 (13:57 +1300)
commit78c0f85e435bf327dcf2c1aded47b51263b32b82
tree0257c2bb22c24f32aa7f54585725bd66bc0d0637
parentd9f7ad54e552262ee0090e88d5abd3e04fcdeac8
Wake up for latches in CheckpointWriteDelay().

The checkpointer shouldn't ignore its latch.  Other backends may be
waiting for it to drain the request queue.  Hopefully real systems don't
have a full queue often, but the condition is reached easily when
shared_buffers is small.

This involves defining a new wait event, which will appear in the
pg_stat_activity view often due to spread checkpoints.

Back-patch only to 14.  Even though the problem exists in earlier
branches too, it's hard to hit there.  In 14 we stopped using signal
handlers for latches on Linux, *BSD and macOS, which were previously
hiding this problem by interrupting the sleep (though not reliably, as
the signal could arrive before the sleep begins; precisely the problem
latches address).

Reported-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20220226213942.nb7uvb2pamyu26dj%40alap3.anarazel.de
doc/src/sgml/monitoring.sgml
src/backend/postmaster/checkpointer.c
src/backend/utils/activity/wait_event.c
src/include/utils/wait_event.h