]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Try harder to remove pr-helper object and kill pr-helper process
authorJie Wang <wangjie88@huawei.com>
Fri, 31 May 2019 07:33:31 +0000 (15:33 +0800)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 14 Jun 2019 07:51:10 +0000 (09:51 +0200)
commit7a232286b9d8c19ad62cb93c19e4651894447743
treed882a6e8447deef0a7585a5b0daa49bcf0cefdf7
parentd5c5d615141343e7016150b6bf2d44e754d08547
qemu: Try harder to remove pr-helper object and kill pr-helper process

If libvirt receives DISCONNECTED event and prDaemonRunning is set
to false, and qemuDomainRemoveDiskDevice() is performing in the
meantime, then qemuDomainRemoveDiskDevice() will fail to remove
pr-helper object because prDaemonRunning is false. But removing
that check from qemuHotplugRemoveManagedPR() is not enough,
because after removing the object through monitor the
qemuProcessKillManagedPRDaemon() is called which contains the
same check. Thus the pr-helper process might be left behind.

Signed-off-by: Jie Wang <wangjie88@huawei.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_hotplug.c
src/qemu/qemu_process.c