]> git.ipfire.org Git - thirdparty/asterisk.git/commit
res_fax.c: Fix deadlock in fax_gateway_indicate_t38(). 03/3703/1
authorRichard Mudgett <rmudgett@digium.com>
Mon, 22 Aug 2016 17:31:24 +0000 (12:31 -0500)
committerRichard Mudgett <rmudgett@digium.com>
Thu, 25 Aug 2016 23:22:21 +0000 (18:22 -0500)
commit8015550116c65b94f11419f95e121d9d85b40889
treee892b42a25d283de735c531ce4735e1d51455cf4
parente79bf5539f3d2560083103281d7131aabc11bdb0
res_fax.c: Fix deadlock in fax_gateway_indicate_t38().

fax_gateway_indicate_t38() calls ast_indicate_data() which cannot be
called with any channel locks already held.  A deadlock can happen if the
function is operating on a local channel.

* Made fax_gateway_indicate_t38() unlock the channel before calling
ast_indicate_data() since fax_gateway_indicate_t38() is always called with
the channel locked.

* Made fax_gateway_indicate_t38() return void since nothing cared about
its return value.

ASTERISK-26203
Reported by: Etienne Lessard

ASTERISK-24822
Reported by: David Brillert

ASTERISK-22732
Reported by: Richard Mudgett

Change-Id: I701ff2d26c5fc23e0d5a48a3fd98759a9fd09407
res/res_fax.c