]> git.ipfire.org Git - thirdparty/glibc.git/commit
ungetc: Fix uninitialized read when putting into unused streams [BZ #27821]
authorSiddhesh Poyarekar <siddhesh@sourceware.org>
Wed, 14 Aug 2024 01:00:06 +0000 (21:00 -0400)
committerSiddhesh Poyarekar <siddhesh@sourceware.org>
Wed, 28 Aug 2024 22:44:07 +0000 (18:44 -0400)
commit810fa2488c140d7ae3c239fa01ec2dd61199cdc0
tree8455c8612088a2524c3e9ea5d2a17aad8cdb700e
parentbb6cfec3ddcf907933fbcf650ce3fdc79c5fe797
ungetc: Fix uninitialized read when putting into unused streams [BZ #27821]

When ungetc is called on an unused stream, the backup buffer is
allocated without the main get area being present.  This results in
every subsequent ungetc (as the stream remains in the backup area)
checking uninitialized memory in the backup buffer when trying to put a
character back into the stream.

Avoid comparing the input character with buffer contents when in backup
to avoid this uninitialized read.  The uninitialized read is harmless in
this context since the location is promptly overwritten with the input
character, thus fulfilling ungetc functionality.

Also adjust wording in the manual to drop the paragraph that says glibc
cannot do multiple ungetc back to back since with this change, ungetc
can actually do this.

Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
(cherry picked from commit cdf0f88f97b0aaceb894cc02b21159d148d7065c)
(cherry picked from commit 804d3c8db79db204154dcf5e11a76f14fdddc570)
libio/genops.c
manual/stdio.texi
stdio-common/tst-ungetc.c