]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs_admin: don't hide the xfs_repair output when upgrading
authorDarrick J. Wong <djwong@kernel.org>
Fri, 12 Mar 2021 18:57:27 +0000 (13:57 -0500)
committerEric Sandeen <sandeen@sandeen.net>
Fri, 12 Mar 2021 18:57:27 +0000 (13:57 -0500)
commit88ad13001735e537cefe27e36fcd02f7c44c6f8c
tree4c4d4007eb6ad534b4b3a9308cbbe9dfe1a2fc28
parent16c64512bbc36e433e31659d8c1348bcb5b36009
xfs_admin: don't hide the xfs_repair output when upgrading

Currently, xfs_admin suppresses the output from xfs_repair when it tries
to upgrade a filesystem, and prints a rather unhelpful message if the
upgrade fails.

Neither of these behaviors are useful -- repair can fail for reasons
outside of the filesystem being mounted, and if it does, the admin will
never know what actually happened.

Worse yet, if repair finds corruptions on disk, the upgrade script
silently throws all that away, which means that nobody will ever be able
to report what happened if an upgrade trashes a filesystem.

Therefore, allow the console to capture all of repair's stdout/stderr
reports.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
db/xfs_admin.sh