]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Refuse ATTACH of a table referenced by a foreign key
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 8 Aug 2024 23:35:13 +0000 (19:35 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 8 Aug 2024 23:35:13 +0000 (19:35 -0400)
commit8c0944ac878d3d3e433da8feb2f7e134be8353f3
tree2ece3788d6ab1b659fb1a108e46cc0b3863717d5
parentb5a5027c9796e2958392f4682928d47b5b0d0e47
Refuse ATTACH of a table referenced by a foreign key

Trying to attach a table as a partition which is already on the
referenced side of a foreign key on the partitioned table that it is
being attached to, leads to strange behavior: we try to clone the
foreign key from the parent to the partition, but this new FK points to
the partition itself, and the mix of pg_constraint rows and triggers
doesn't behave well.

Rather than trying to untangle the mess (which might be possible given
sufficient time), I opted to forbid the ATTACH.  This doesn't seem a
problematic restriction, given that we already fail to create the
foreign key if you do it the other way around, that is, having the
partition first and the FK second.

Backpatch to all supported branches.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Tender Wang <tndrwang@gmail.com>
Discussion: https://postgr.es/m/18541-628a61bc267cd2d3@postgresql.org
src/backend/commands/tablecmds.c
src/test/regress/expected/foreign_key.out
src/test/regress/sql/foreign_key.sql