]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Avoid low-probability regression test failures in timestamp[tz] tests.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 22 Dec 2019 23:00:18 +0000 (18:00 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 22 Dec 2019 23:00:18 +0000 (18:00 -0500)
commit8f735c0488c68d02ed9a484851277fd5df4570c5
tree38f3f391aeff77346db498b15328416ba64a012a
parentf1a4020ef3bbb9381a43972f33159dc5a6132758
Avoid low-probability regression test failures in timestamp[tz] tests.

If the first transaction block in these tests were entered exactly
at midnight (California time), they'd report a bogus failure due
to 'now' and 'midnight' having the same values.  Commit 8c2ac75c5
had dismissed this as being of negligible probability, but we've
now seen it happen in the buildfarm, so let's prevent it.  We can
get pretty much the same test coverage without an it's-not-midnight
assumption by moving the does-'now'-work cases into their own test step.

While here, apply commit 47169c255's s/DELETE/TRUNCATE/ change to
timestamptz as well as timestamp (not sure why that didn't
occur to me at the time; the risk of failure is the same).

Back-patch to all supported branches, since the main point is
to get rid of potential buildfarm failures.

Discussion: https://postgr.es/m/14821.1577031117@sss.pgh.pa.us
src/test/regress/expected/timestamp.out
src/test/regress/expected/timestamptz.out
src/test/regress/sql/timestamp.sql
src/test/regress/sql/timestamptz.sql