]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Suppress variable-set-but-not-used warning from clang 13.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Jan 2022 16:09:00 +0000 (11:09 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Jan 2022 16:09:58 +0000 (11:09 -0500)
commit927e235aa0f6ce598eee9f251e09653a015974d8
tree49bf1877cca726cc0d220e7018ac5bece2da98fc
parent0af208402d0a5cede0e8c9007112233032dab639
Suppress variable-set-but-not-used warning from clang 13.

In the normal configuration where GEQO_DEBUG isn't defined,
recent clang versions have started to complain that geqo_main.c
accumulates the edge_failures count but never does anything
with it.  As a minimal back-patchable fix, insert a void cast
to silence this warning.  (I'd speculated about ripping out the
GEQO_DEBUG logic altogether, but I don't think we'd wish to
back-patch that.)

Per recently-established project policy, this is a candidate
for back-patching into out-of-support branches: it suppresses
an annoying compiler warning but changes no behavior.  Hence,
back-patch all the way to 9.2.

Discussion: https://postgr.es/m/CA+hUKGLTSZQwES8VNPmWO9AO0wSeLt36OCPDAZTccT1h7Q7kTQ@mail.gmail.com
src/backend/optimizer/geqo/geqo_main.c