]> git.ipfire.org Git - thirdparty/asterisk.git/commit
sig_analog: Fix broken three-way conferencing.
authorNaveen Albert <asterisk@phreaknet.org>
Fri, 13 May 2022 12:33:21 +0000 (12:33 +0000)
committerFriendly Automation <jenkins2@gerrit.asterisk.org>
Wed, 15 Jun 2022 17:21:23 +0000 (12:21 -0500)
commita57e36edfc51c1039b36e5ab08773bc813edc34f
treec46f2324540bb01b867223750861166ab001a3d8
parent5fe8583611de78a0d741183d2abda2ff2b6573de
sig_analog: Fix broken three-way conferencing.

Three-way calling for analog lines is currently broken.
If party A is on a call with party B and initiates a
three-way call to party C, the behavior differs depending
on whether the call is conferenced prior to party C
answering. The post-answer case is correct. However,
if A flashes before C answers, then the next flash
disconnects B rather than C, which is incorrect.

This error occurs because the subs are not swapped
in the misbehaving case. This is because the flash
handler only swaps the subs if C has answered already,
which is wrong. To fix this, we swap the subs regardless
of whether C has answered or not when the call is
conferenced. This ensures that C is disconnected
on the next hook flash, rather than B as can happen
currently.

ASTERISK-30043 #close

Change-Id: I96c5bf6c9b7eb2636136b716c677c82c079b6f06
channels/sig_analog.c