]> git.ipfire.org Git - thirdparty/vim.git/commit
patch 9.0.2108: [security]: overflow with count for :s command v9.0.2108
authorChristian Brabandt <cb@256bit.org>
Tue, 14 Nov 2023 19:45:48 +0000 (20:45 +0100)
committerChristian Brabandt <cb@256bit.org>
Thu, 16 Nov 2023 21:04:37 +0000 (22:04 +0100)
commitac63787734fda2e294e477af52b3bd601517fa78
tree79a2df1e1b876a0920d47585343519aa4f8e3b9b
parentcb0b99f0672d8446585d26e998343dceca17d1ce
patch 9.0.2108: [security]: overflow with count for :s command

Problem:  [security]: overflow with count for :s command
Solution: Abort the :s command if the count is too large

If the count after the :s command is larger than what fits into a
(signed) long variable, abort with e_value_too_large.

Adds a test with INT_MAX as count and verify it correctly fails.

It seems the return value on Windows using mingw compiler wraps around,
so the initial test using :s/./b/9999999999999999999999999990 doesn't
fail there, since the count is wrapping around several times and finally
is no longer larger than 2147483647. So let's just use 2147483647 in the
test, which hopefully will always cause a failure

Signed-off-by: Christian Brabandt <cb@256bit.org>
runtime/doc/change.txt
runtime/doc/cmdline.txt
runtime/doc/tags
src/ex_cmds.c
src/testdir/test_substitute.vim
src/version.c