]> git.ipfire.org Git - thirdparty/postgresql.git/commit
TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 19 Jan 2022 21:29:09 +0000 (16:29 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 19 Jan 2022 21:29:09 +0000 (16:29 -0500)
commitb0623625a0a30d66e991deab6488c59bb63ea20e
treebf8c07900871fb257d6c5cdf4e27ac9afd4df6ea
parent0f1367c9f381aae523f6557c0ee28a800b3eace7
TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.

"pg_ctl start" might start a new postmaster and then return failure
anyway, for example if PGCTLTIMEOUT is exceeded.  If there is a
postmaster there, it's still incumbent on us to shut it down at
script end, so check for the PID file even though we are about
to fail.

This has been broken all along, so back-patch to all supported branches.

Discussion: https://postgr.es/m/647439.1642622744@sss.pgh.pa.us
src/test/perl/PostgresNode.pm