]> git.ipfire.org Git - thirdparty/libbsd.git/commit
test: nlist: make resilient against -Wl,--gc-sections
authorSam James <sam@gentoo.org>
Wed, 13 Mar 2024 23:34:55 +0000 (23:34 +0000)
committerGuillem Jover <guillem@hadrons.org>
Thu, 14 Mar 2024 08:33:34 +0000 (09:33 +0100)
commitb62f36f3055262faf28e4ff12dd7ed03c44e09d8
tree8707b5123e78589920ab80ae59dbaad1dd460005
parent2a3d521318533bb1d0535b989be578b4f5c5ff1a
test: nlist: make resilient against -Wl,--gc-sections

With linker sections GC enabled, we get a test failure in `nlist.c`:
```
nlist: nlist.c:72: main: Assertion `rc == 0' failed.
```

This turns out to be because several sections used by the test can be discarded:
```
ld: removing unused section '.text.func_pub' in file 'nlist.o'
ld: removing unused section '.bss.data_pub_uninit' in file 'nlist.o'
ld: removing unused section '.data.data_pub_init' in file 'nlist.o'
```

Reproduced with `CFLAGS="-Og -fdata-sections -ffunction-sections"` and
`LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--gc-sections -Wl,-z,start-stop-gc"`.

Additionally, `LDFLAGS="... -Wl,--print-gc-sections"` can help with diagnosing
which sections get removed.

We already mark these symbols as `used`, but we need `retain` [0] for them
to survive linker GC too.

[0] https://releases.llvm.org/18.1.0/tools/lld/docs/ELF/start-stop-gc.html#annotate-c-identifier-name-sections

Closes: !29
Signed-off-by: Sam James <sam@gentoo.org>
Signed-off-by: Guillem Jover <guillem@hadrons.org>
test/nlist.c