]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Refactor Copy{From|To}GetRoutine() to use pass-by-reference argument.
authorMasahiko Sawada <msawada@postgresql.org>
Tue, 4 Mar 2025 18:38:41 +0000 (10:38 -0800)
committerMasahiko Sawada <msawada@postgresql.org>
Tue, 4 Mar 2025 18:38:41 +0000 (10:38 -0800)
commitbacbc4863b3bfb79b9577f11f2c77e4df9f66d66
treedd242c1aa05c18d264f4d3fe5b890018e9e01b3e
parent0b2a45a5d1f2b088640a7eb7817ca6a0513a2717
Refactor Copy{From|To}GetRoutine() to use pass-by-reference argument.

The change improves efficiency by eliminating unnecessary copying of
CopyFormatOptions.

The coverity also complained about inefficiencies caused by
pass-by-value.

Oversight in 7717f6300 and 2e4127b6d.

Reported-by: Junwang Zhao <zhjwpku@gmail.com>
Reported-by: Tom Lane <tgl@sss.pgh.pa.us> (per reports from coverity)
Author: Sutou Kouhei <kou@clear-code.com>
Reviewed-by: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3L6YCpPksTQMzjD_CvwDEhW3D_t=5md9BvvdOs5k+TA=Q@mail.gmail.com
src/backend/commands/copyfrom.c
src/backend/commands/copyto.c