]> git.ipfire.org Git - thirdparty/squid.git/commit
fixup: Moved Job_type-agnostic JobWait code to a .cc file
authorAlex Rousskov <rousskov@measurement-factory.com>
Thu, 15 Jul 2021 20:49:36 +0000 (16:49 -0400)
committerAlex Rousskov <rousskov@measurement-factory.com>
Fri, 16 Jul 2021 17:33:09 +0000 (13:33 -0400)
commitbe9f295b6a528031c4174da3acea1a43121521d3
tree47e0933aaf7c72b3c5b9aeead157e6fa3d44f8b7
parent136c05747134fe3bb266f82b5055a8d6cfd43c42
fixup: Moved Job_type-agnostic JobWait code to a .cc file

It is possible to make most JobWait users template-free. I have done
that and reverted those changes because they:

* Decrease code readability: The wait member declaration no longer makes
  it clear what job kind that wait member is waiting for/dedicated to.

* Decrease JobWait safety (a user may give the wrong job to the
  wait.start() call)

* Require strange/ugly tricks to make sure that users of the templated
  version do not call the non-templated start() which does not set the
  type-aware JobWaitAndCommunicate job_ member.

A couple of other, very minor JobWait polishing touches.
src/base/AsyncJobCalls.cc [new file with mode: 0644]
src/base/AsyncJobCalls.h
src/base/Makefile.am