]> git.ipfire.org Git - thirdparty/u-boot.git/commit
net: Incorrect NOP macro used for test
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Tue, 8 Jul 2025 16:51:17 +0000 (17:51 +0100)
committerJerome Forissier <jerome.forissier@linaro.org>
Fri, 1 Aug 2025 07:30:47 +0000 (09:30 +0200)
commitc29c5ed2966425a14aab6794e739a78ab46178a5
tree89147f6758090d92d555833eced628a2aacbd214
parent31a8d2d34082ff6d1e2989912a373aed3f080fb6
net: Incorrect NOP macro used for test

In tcp_parse_options the uchar p[0] is attempted to test for a match
with the 32bit macro TCP_0_NOP which can never be true. Instead test
against the 8bit macro TCP_1_NOP.

This issue found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
net/tcp.c