]> git.ipfire.org Git - thirdparty/grub.git/commit
kern/parser: Fix resource leak if argc == 0
authorDarren Kenny <darren.kenny@oracle.com>
Fri, 22 Jan 2021 12:32:41 +0000 (12:32 +0000)
committerDaniel Kiper <daniel.kiper@oracle.com>
Tue, 2 Mar 2021 14:54:16 +0000 (15:54 +0100)
commitd06161b035dde4769199ad65aa0a587a5920012b
treedae4a02ce88a09f3e1a9acc053bcd122e85996e1
parent0cb838b281a68b536a09681f9557ea6a7ac5da7a
kern/parser: Fix resource leak if argc == 0

After processing the command-line yet arriving at the point where we are
setting argv, we are allocating memory, even if argc == 0, which makes
no sense since we never put anything into the allocated argv.

The solution is to simply return that we've successfully processed the
arguments but that argc == 0, and also ensure that argv is NULL when
we're not allocating anything in it.

There are only 2 callers of this function, and both are handling a zero
value in argc assuming nothing is allocated in argv.

Fixes: CID 96680
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
grub-core/kern/parser.c