]> git.ipfire.org Git - thirdparty/libtool.git/commit
syntax-check: [REDO] fix violations and implement sc_prohibit_test_const_follows_var.
authorGary V. Vaughan <gary@gnu.org>
Tue, 2 Oct 2012 02:40:40 +0000 (09:40 +0700)
committerGary V. Vaughan <gary@gnu.org>
Tue, 2 Oct 2012 14:02:16 +0000 (21:02 +0700)
commitd43b40113ec1e8289e48d77f00e8947f2fd98fd4
treef3e680c259b71726b2acc5beeed676903366cce7
parent8fad6be03e8eca44e5e771cfbb907d3840a8e01e
syntax-check: [REDO] fix violations and implement sc_prohibit_test_const_follows_var.

To safely use a non-literal fist argument to 'test', you must
always prepend a literal non-'-' character, but often the second
operand is a constant that doesn't begin with a '-' already, so
always use 'test a = "$b"' instead of the noisy 'test "X$b" = Xa'.
* cf.mk (sc_prohibit_test_const_follws_var): New syntax-check
rule to ensure we don't reintroduce noisy test operands.
bootstrap, build-aux/extract-trace, build-aux/general.m4sh,
build-aux/ltmain.m4sh, configure.ac, doc/libtool.texi, libtoolize.m4sh,
m4/argz.m4, m4/libtool.m4, m4/ltdl.m4, tests/bindir.at, tests/defs.m4sh,
tests/demo-relink.test, tests/demo/configure.ac,
tests/depdemo-relink.test, tests/destdir.at, tests/duplicate_conv.at,
tests/fail.at, tests/getopt-m4sh.at, tests/help.at, tests/libtoolize.at,
tests/link-2.test, tests/link-order2.at, tests/lt_dlopenext.at,
tests/mdemo/configure.ac, tests/mdemo2/configure.ac,
tests/need_lib_prefix.at, tests/nocase.at, tests/pdemo/configure.ac,
tests/pic_flag.at, tests/search-path.at, tests/shlibpath.at,
tests/static.at, tests/sysroot.at, tests/tagtrace.test,
tests/testsuite.at, tests/with-pic.at: Swap operands to avoid useless
noise.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>
38 files changed:
bootstrap
build-aux/extract-trace
build-aux/general.m4sh
build-aux/ltmain.m4sh
cfg.mk
configure.ac
doc/libtool.texi
libtoolize.m4sh
m4/argz.m4
m4/libtool.m4
m4/ltdl.m4
tests/bindir.at
tests/defs.m4sh
tests/demo-relink.test
tests/demo/configure.ac
tests/depdemo-relink.test
tests/destdir.at
tests/duplicate_conv.at
tests/fail.at
tests/getopt-m4sh.at
tests/help.at
tests/libtoolize.at
tests/link-2.test
tests/link-order2.at
tests/lt_dlopenext.at
tests/mdemo/configure.ac
tests/mdemo2/configure.ac
tests/need_lib_prefix.at
tests/nocase.at
tests/pdemo/configure.ac
tests/pic_flag.at
tests/search-path.at
tests/shlibpath.at
tests/static.at
tests/sysroot.at
tests/tagtrace.test
tests/testsuite.at
tests/with-pic.at