]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Extend int128.h to support more numeric code.
authorDean Rasheed <dean.a.rasheed@gmail.com>
Thu, 7 Aug 2025 14:49:24 +0000 (15:49 +0100)
committerDean Rasheed <dean.a.rasheed@gmail.com>
Thu, 7 Aug 2025 14:49:24 +0000 (15:49 +0100)
commitd699687b329e031cd90e967b39c3fd8a53ef8208
tree94063e5b131259f05e33e5933128fff516ddcf0f
parent0ef891e54175c6646a132bc00e330ff64edb9888
Extend int128.h to support more numeric code.

This adds a few more functions to int128.h, allowing more of numeric.c
to use 128-bit integers on all platforms.

Specifically, int64_div_fast_to_numeric() and the following aggregate
functions can now use 128-bit integers for improved performance on all
platforms, rather than just platforms with native support for int128:

- SUM(int8)
- AVG(int8)
- STDDEV_POP(int2 or int4)
- STDDEV_SAMP(int2 or int4)
- VAR_POP(int2 or int4)
- VAR_SAMP(int2 or int4)

In addition to improved performance on platforms lacking native
128-bit integer support, this significantly simplifies this numeric
code by allowing a lot of conditionally compiled code to be deleted.

A couple of numeric functions (div_var_int64() and sqrt_var()) still
contain conditionally compiled 128-bit integer code that only works on
platforms with native 128-bit integer support. Making those work more
generally would require rolling our own higher precision 128-bit
division, which isn't supported for now.

Author: Dean Rasheed <dean.a.rasheed@gmail.com>
Reviewed-by: John Naylor <johncnaylorls@gmail.com>
Discussion: https://postgr.es/m/CAEZATCWgBMc9ZwKMYqQpaQz2X6gaamYRB+RnMsUNcdMcL2Mj_w@mail.gmail.com
src/backend/utils/adt/numeric.c
src/include/common/int128.h
src/test/modules/test_int128/test_int128.c
src/test/regress/expected/aggregates.out
src/test/regress/sql/aggregates.sql