]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Be more careful about time_t vs. pg_time_t in basebackup.c.
authorRobert Haas <rhaas@postgresql.org>
Sat, 4 Apr 2020 00:15:27 +0000 (20:15 -0400)
committerRobert Haas <rhaas@postgresql.org>
Sat, 4 Apr 2020 00:18:47 +0000 (20:18 -0400)
commitdb1531cae00941bfe4f6321fdef1e1ef355b6bed
tree81f9c505167f9348d869653ae6bfb2c8cd0f6843
parent9f8f881caa0fabdf7ff46cc55a991ffeab39bd92
Be more careful about time_t vs. pg_time_t in basebackup.c.

lapwing is complaining that about a call to pg_gmtime, saying that
it "expected 'const pg_time_t *' but argument is of type 'time_t *'".
I at first thought that the problem had someting to do with const,
but Thomas Munro suggested that it might be just because time_t
and pg_time_t are different identifers. lapwing is i686 rather than
x86_64, and pg_time_t is always int64, so that seems like a good
guess.

There is other code that just casts time_t to pg_time_t without
any conversion function, so try that approach here.

Introduced in commit 0d8c9c1210c44b36ec2efcb223a1dfbe897a3661.
src/backend/replication/basebackup.c