]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Keep WAL segments by the flushed value of the slot's restart LSN
authorAlexander Korotkov <akorotkov@postgresql.org>
Sat, 14 Jun 2025 00:33:15 +0000 (03:33 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Sat, 14 Jun 2025 01:15:04 +0000 (04:15 +0300)
commitdd9bc1a17d0324448c45c6fc0a2d258b9134bfc3
treee5261792f17c11894934581e20d14c3d3b9acc4c
parentd2ec671092a1144fcaa6b465b4672e937a68b65f
Keep WAL segments by the flushed value of the slot's restart LSN

The patch fixes the issue with the unexpected removal of old WAL segments
after checkpoint, followed by an immediate restart.  The issue occurs when
a slot is advanced after the start of the checkpoint and before old WAL
segments are removed at the end of the checkpoint.

The idea of the patch is to get the minimal restart_lsn at the beginning
of checkpoint (or restart point) creation and use this value when calculating
the oldest LSN for WAL segments removal at the end of checkpoint.  This idea
was proposed by Tomas Vondra in the discussion.  Unlike 291221c46575, this
fix doesn't affect ABI and is intended for back branches.

Discussion: https://postgr.es/m/flat/1d12d2-67235980-35-19a406a0%4063439497
Author: Vitaly Davydov <v.davydov@postgrespro.ru>
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 13
src/backend/access/transam/xlog.c
src/backend/replication/logical/logical.c
src/backend/replication/walsender.c