]> git.ipfire.org Git - thirdparty/asterisk.git/commit
AST-2017-012: Place single RTCP report block at beginning of report.
authorJoshua Colp <jcolp@digium.com>
Thu, 30 Nov 2017 16:12:55 +0000 (16:12 +0000)
committerJoshua Colp <jcolp@digium.com>
Wed, 13 Dec 2017 14:20:50 +0000 (08:20 -0600)
commitdee00fd80b697e3a704bb6964ee8e4b7e9ea52bd
treee155951cf782fa2093d2cdfe138855658cf4cd63
parentc47e07120eb561dbd972522a8f5a213f730317f3
AST-2017-012: Place single RTCP report block at beginning of report.

When the RTCP code was transitioned over to Stasis a code change
was made to keep track of how many reports are present. This count
controlled where report blocks were placed in the RTCP report.

If a compound RTCP packet was received this logic would incorrectly
place a report block in the wrong location resulting in a write
to an invalid location.

This change removes this counting logic and always places the report
block at the first position. If in the future multiple reports are
supported the logic can be extended but for now keeping a count
serves no purpose.

ASTERISK-27382
ASTERISK-27429

Change-Id: Iad6c8a9985c4b608ef493e19c421211615485116
(cherry picked from commit fb18797ae09a685ec71101499fb1c1c606b16397)
res/res_rtp_asterisk.c