]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes
authorMatthias Schiffer <matthias.schiffer@ew.tq-group.com>
Tue, 24 Jun 2025 10:53:34 +0000 (12:53 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 26 Jun 2025 12:49:10 +0000 (14:49 +0200)
commite02adac7c84bf2883ce5d5a828a03871c0c1d4f9
tree0f9b811ef8cedfcc53ff173de8271cc0621371c6
parentca13b249f291f4920466638d1adbfb3f9c8db6e9
checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes

Historically, the RGMII PHY modes specified in Device Trees have been
used inconsistently, often referring to the usage of delays on the PHY
side rather than describing the board; many drivers still implement this
incorrectly.

Require a comment in Devices Trees using these modes (usually mentioning
that the delay is realized on the PCB), so we can avoid adding more
incorrect uses (or will at least notice which drivers still need to be
fixed).

Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/bc112b8aa510cf9df9ab33178d122f234d0aebf7.1750756583.git.matthias.schiffer@ew.tq-group.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Documentation/dev-tools/checkpatch.rst
scripts/checkpatch.pl