]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Do not skip ERROR:/SUCCESS: response from management interface
authorSelva Nair <selva.nair@gmail.com>
Thu, 28 Jul 2022 03:45:07 +0000 (23:45 -0400)
committerGert Doering <gert@greenie.muc.de>
Tue, 2 Aug 2022 11:50:59 +0000 (13:50 +0200)
commite3c397b0edd86158b8c417f6d396920a7e2eae68
tree711fa032b3919c6bee9cd7910b38bdc2bcaad481
parentce24bec7e2518d4ea7aa931021454d1191f4906b
Do not skip ERROR:/SUCCESS: response from management interface

Generally we expect a response of SUCCESS: or ERROR: to every
command sent to the management interface. But, while in
the management-hold state, sending "signal foo" returns only
the following reply (with foo = SIGHUP, SIGUSR1 etc.):

>HOLD:Waiting for hold release:0

Fix by always responding

ERROR: signal 'foo' is currently ignored"
followed by the above line.

Though this is seldom seen in practice[*], such violation of the
protocol could stall clients like the GUI. So fix it.

[*] One way this happens is with SIGHUP sent before the daemon
is on hold state which it enters before the SIGHUP is received.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <20220728034508.15180-1-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24750.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 579b78e22feab7fe7cc627355cbb270cd91aebb4)
src/openvpn/manage.c