]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix corner case in NTLM authentication (trac #172)
authorChristian Niessner <openvpn@christian-niessner.de>
Thu, 7 Mar 2013 18:37:58 +0000 (19:37 +0100)
committerGert Doering <gert@greenie.muc.de>
Sun, 30 Nov 2014 17:51:34 +0000 (18:51 +0100)
commite5e01614c479e714aa3754050725692ec0b5c6f0
treec184772ed1c6fdfca35c4151f0b7a0db2181c189
parent1ef95ee21627d7099a7acfed93743fefe4968b7d
Fix corner case in NTLM authentication (trac #172)

The problem is located in the file proxy.c within
"establish_http_proxy_passthru": To keep buffers small long
base64-encoded NTLM-Strings are truncated.

But the truncating is done on a wrong place: base 64 strings can be
cut every 4 chars. the buffer is 128 bytes - including the terminating
\0, so the usable data is only 127 bytes. And decoding a 127 char
base64 string fails... this is why the ntlm authentication fails in
certain cases (long strings)...

Acked-by: Joerg Willmann <joe@clnt.de>
URL: https://community.openvpn.net/openvpn/ticket/172

Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit f8ac53b98ed2513f1d80363b6fd2351f1b4ae511)
proxy.c