]> git.ipfire.org Git - thirdparty/vim.git/commit
patch 9.1.0061: UX of visual highlighting can be improved v9.1.0061
authorChristian Brabandt <cb@256bit.org>
Sun, 28 Jan 2024 22:33:29 +0000 (23:33 +0100)
committerChristian Brabandt <cb@256bit.org>
Sun, 28 Jan 2024 22:38:28 +0000 (23:38 +0100)
commite6d8b4662ddf9356da53f56e363b67b524fd8825
treed93055a5466e8987dfbd7f9f5281740f5220702c
parentbdb9d9afba9769b1cb9c0b320086142d99034c9a
patch 9.1.0061: UX of visual highlighting can be improved

Problem:  UX of visual highlighting can be improved
Solution: Improve readibility of visual highlighting,
          by setting better foreground and background
          colors

The default visual highlighting currently is nice in that it overlays
the actual syntax highlighting by using a separate distinct background
color.

However, this can cause hard to read text, because the contrast
between the actual syntax element and the background color is way too
low. That is an issue, that has been bothering colorschemes authors for
quite some time so much, that they are defining the Visual highlighting
group to use a separate foreground and background color, so that the
syntax highlighting vanishes, but the text remains readable (ref:
vim/colorschemes#250)

So this is an attempt to perform the same fix for the default Visual
highlighting and just use a default foreground and background color
instead of using reverse.

I also removed the hard-coded changes to the Visual highlighting in
init_highlight. It's not quite clear to me, why those were there and not
added directly to the highlighting_init_<dark|light> struct.

closes: #13663
related: vim/colorschemes#250

Signed-off-by: Christian Brabandt <cb@256bit.org>
40 files changed:
src/highlight.c
src/testdir/dumps/Test_balloon_eval_term_02.dump
src/testdir/dumps/Test_cursorline_with_visualmode_01.dump
src/testdir/dumps/Test_display_scroll_update_visual.dump
src/testdir/dumps/Test_echowin_showmode.dump
src/testdir/dumps/Test_hlsearch_visual_1.dump
src/testdir/dumps/Test_popup_command_03.dump
src/testdir/dumps/Test_prop_inserts_text_1.dump
src/testdir/dumps/Test_prop_inserts_text_2.dump
src/testdir/dumps/Test_prop_inserts_text_3.dump
src/testdir/dumps/Test_prop_inserts_text_4.dump
src/testdir/dumps/Test_prop_inserts_text_5.dump
src/testdir/dumps/Test_prop_inserts_text_6.dump
src/testdir/dumps/Test_prop_inserts_text_visual_block_2.dump
src/testdir/dumps/Test_prop_inserts_text_visual_block_3.dump
src/testdir/dumps/Test_prop_inserts_text_visual_block_4.dump
src/testdir/dumps/Test_prop_inserts_text_visual_block_5.dump
src/testdir/dumps/Test_prop_inserts_text_visual_block_6.dump
src/testdir/dumps/Test_prop_inserts_text_visual_block_7.dump
src/testdir/dumps/Test_prop_with_text_above_6.dump
src/testdir/dumps/Test_prop_with_text_above_7.dump
src/testdir/dumps/Test_prop_with_text_empty_line_6.dump
src/testdir/dumps/Test_prop_with_text_override_2.dump
src/testdir/dumps/Test_statusline_showcmd_3.dump
src/testdir/dumps/Test_syntax_c_01.dump
src/testdir/dumps/Test_tabline_showcmd_3.dump
src/testdir/dumps/Test_terminal_popup_7.dump
src/testdir/dumps/Test_textprop_hl_override_2.dump
src/testdir/dumps/Test_vim9_no_redraw.dump
src/testdir/dumps/Test_visual_block_with_virtualedit.dump
src/testdir/dumps/Test_visual_block_with_virtualedit2.dump
src/testdir/dumps/Test_visual_hl_with_showbreak.dump
src/testdir/dumps/Test_visual_sbr_1.dump
src/testdir/dumps/Test_visual_starts_before_skipcol_1.dump
src/testdir/dumps/Test_visual_starts_before_skipcol_2.dump
src/testdir/dumps/Test_visual_starts_before_skipcol_3.dump
src/testdir/dumps/Test_visual_starts_before_skipcol_4.dump
src/testdir/dumps/Test_win_gotoid_2.dump
src/testdir/dumps/Test_wincolor_01.dump
src/version.c