]> git.ipfire.org Git - thirdparty/samba.git/commit
s3:auth: Avoid passing freed pamh pointer to funcitons using it
authorAndreas Schneider <asn@samba.org>
Mon, 24 Jun 2024 08:20:51 +0000 (10:20 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Fri, 28 Jun 2024 11:39:33 +0000 (11:39 +0000)
commitec7dfedccf6b30c69398b8473b503c7d19b132cf
treea7aed348fdf2efcd7535bfb8e32056206da6474f
parent990a68fedb9ac33de8b52b4091c6152c76fbbd7e
s3:auth: Avoid passing freed pamh pointer to funcitons using it

"Error: USE_AFTER_FREE (CWE-416):
samba-4.20.0rc2/source3/auth/pampass.c:466: freed_arg: ""pam_end"" frees ""pamh"".
samba-4.20.0rc2/source3/auth/pampass.c:467: pass_freed_arg: Passing freed pointer ""pamh"" as an argument to ""smb_pam_error_handler"".
  465|    if( pamh != NULL ) {
  466|    pam_error = pam_end(pamh, 0);
  467|->  if(smb_pam_error_handler(pamh, pam_error, ""End Cleanup Failed"", 2) == True) {
  468|    DEBUG(4, (""smb_pam_end: PAM: PAM_END OK.\n""));
  469|    return True;"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
source3/auth/pampass.c