]> git.ipfire.org Git - thirdparty/FORT-validator.git/commit
Stop dropping old deltas when there are no new deltas
authorAlberto Leiva Popper <ydahhrk@gmail.com>
Mon, 4 Dec 2023 20:25:38 +0000 (17:25 -0300)
committerAlberto Leiva Popper <ydahhrk@gmail.com>
Mon, 4 Dec 2023 20:39:46 +0000 (17:39 -0300)
commitec918adeb0e641d41ee2571fd717cad139d939ad
treeb839329cef11ed6d40f1c4141880277323e6ae8e
parentcd59667dc231d47e301a3e3d94e69ae1f01e0c61
Stop dropping old deltas when there are no new deltas

__vrps_update() wasn't properly differentiating between a validation
cycle that errored from one that generated no deltas. Both were being
handled as failure.

Therefore, Fort might have been inducing more RTR Cache Resets than it
was supposed to. Although, iterations in which no deltas are generated
seem to be rare.

The removal of surplus error propagation in the previous commit
revealed that compute_deltas() cannot actually fail, which made
the solution here trivial.
src/rtr/db/vrps.c