]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix incorrect lack of Datum conversion in _int_matchsel() REL_15_STABLE github/REL_15_STABLE
authorPeter Eisentraut <peter@eisentraut.org>
Fri, 8 Aug 2025 10:06:06 +0000 (12:06 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Fri, 8 Aug 2025 10:10:57 +0000 (12:10 +0200)
commitf0d55b68ef920b5ed22c3788a5dfc15fe1f70be7
treef7498a17843676ba1f8e7a03850ce05ba800a797
parentf39a7f32aefcd424bdbe001f08718eaad5170d6b
Fix incorrect lack of Datum conversion in _int_matchsel()

The code used

    return (Selectivity) 0.0;

where

    PG_RETURN_FLOAT8(0.0);

would be correct.

On 64-bit systems, these are pretty much equivalent, but on 32-bit
systems, PG_RETURN_FLOAT8() correctly produces a pointer, but the old
wrong code would return a null pointer, possibly leading to a crash
elsewhere.

We think this code is actually not reachable because bqarr_in won't
accept an empty query, and there is no other function that will
create query_int values.  But better be safe and not let such
incorrect code lie around.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/8246d7ff-f4b7-4363-913e-827dadfeb145%40eisentraut.org
contrib/intarray/_int_selfuncs.c