]> git.ipfire.org Git - thirdparty/asterisk.git/commit
app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE.
authorWalter Doekes <walter+asterisk@wjd.nu>
Thu, 30 Oct 2014 09:11:39 +0000 (09:11 +0000)
committerWalter Doekes <walter+asterisk@wjd.nu>
Thu, 30 Oct 2014 09:11:39 +0000 (09:11 +0000)
commitf30c13bbedb6f3498aa09781bd1d25f755c1cd42
treee999c759b37b7a31f563479bb1280fe14e2becdf
parent04802b1f091d4d3bdd1f16fcd629bdfc62f5b6a6
app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE.

In update_messages_by_imapuser(), messages were appended to a finite
array which resulted in a crash when an IMAP mailbox contained more
than 256 entries. This memory is now dynamically increased as needed.

Observe that this patch adds a bunch of XXX's to questionable code. See
the review (url below) for more information.

ASTERISK-24190 #close
Reported by: Nick Adams
Tested by: Nick Adams

Review: https://reviewboard.asterisk.org/r/4126/

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426691 65c4cc65-6c06-0410-ace0-fbb531ad65f3
apps/app_voicemail.c