]> git.ipfire.org Git - thirdparty/kea.git/commit
perfdhcp avalanche: improvements after review
authorMichal Nowikowski <godfryd@isc.org>
Mon, 18 Feb 2019 12:30:40 +0000 (13:30 +0100)
committerMichal Nowikowski <godfryd@isc.org>
Tue, 19 Feb 2019 20:54:31 +0000 (21:54 +0100)
commitf4a2c50d4aae45c7f83440c8d2015481e93bb7ad
tree21132a658102bdef44013798b21248dc3a8205c6
parent098ff98fef692bac8de284ff6bf94985a3aa61cb
perfdhcp avalanche: improvements after review

- CommandOptions is no longer a signleton - this makes testing easier
- added -i option taking into account in Avalanche scen (execute only DO exchange)
- fixed collecting stats in Avalanche scen
- improved TestControl tests, moved some of them to BasicScen tests
- made PerfSocket testable: it has a base class which is used for mocking in TestControl tests
- all references to another singleton, IfaceMgr wrapped into PerfSocket - this makes testing easier
- added unit tests for basic and avalanche scenarios, and perf socket
- added -Werror to prevent ignore warnings
- added more comments
27 files changed:
src/bin/perfdhcp/Makefile.am
src/bin/perfdhcp/abstract_scen.h
src/bin/perfdhcp/avalanche_scen.cc
src/bin/perfdhcp/avalanche_scen.h
src/bin/perfdhcp/basic_scen.cc
src/bin/perfdhcp/basic_scen.h
src/bin/perfdhcp/command_options.cc
src/bin/perfdhcp/command_options.h
src/bin/perfdhcp/main.cc
src/bin/perfdhcp/perf_socket.cc
src/bin/perfdhcp/perf_socket.h
src/bin/perfdhcp/receiver.cc
src/bin/perfdhcp/receiver.h
src/bin/perfdhcp/stats_mgr.cc
src/bin/perfdhcp/stats_mgr.h
src/bin/perfdhcp/test_control.cc
src/bin/perfdhcp/test_control.h
src/bin/perfdhcp/tests/Makefile.am
src/bin/perfdhcp/tests/avalanche_scen_unittest.cc [new file with mode: 0644]
src/bin/perfdhcp/tests/basic_scen_unittest.cc [new file with mode: 0644]
src/bin/perfdhcp/tests/command_options_helper.h
src/bin/perfdhcp/tests/command_options_unittest.cc
src/bin/perfdhcp/tests/perf_socket_unittest.cc [new file with mode: 0644]
src/bin/perfdhcp/tests/receiver_unittest.cc
src/bin/perfdhcp/tests/stats_mgr_unittest.cc
src/bin/perfdhcp/tests/test_control_unittest.cc
src/lib/dhcp/pkt.h