]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs_repair: complain about free space only seen by one btree
authorDarrick J. Wong <darrick.wong@oracle.com>
Fri, 10 Jul 2020 19:35:45 +0000 (15:35 -0400)
committerEric Sandeen <sandeen@sandeen.net>
Fri, 10 Jul 2020 19:35:45 +0000 (15:35 -0400)
commitf4cea8e84fd508c8483d0018d9a5c0e016dd29a2
treefb88a35dccf3b7665d4e89d4d071c5f06228e496
parent15fd0ca2c1af9288406acefafdd426ac12868c62
xfs_repair: complain about free space only seen by one btree

During the free space btree walk, scan_allocbt claims in a comment that
we'll catch FREE1 blocks (i.e. blocks that were seen by only one free
space btree) later.  This never happens, with the result that xfs_repair
in dry-run mode can return 0 on a filesystem with corrupt free space
btrees.

Found by fuzzing xfs/358 with numrecs = middlebit (or sub).

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
repair/phase4.c