]> git.ipfire.org Git - thirdparty/asterisk.git/commit
bridges/bridge_softmix: Remove SSRC changes on join/leave; update video source 09/4309/1
authorMatt Jordan <mjordan@digium.com>
Fri, 4 Nov 2016 20:33:35 +0000 (15:33 -0500)
committerMatt Jordan <mjordan@digium.com>
Fri, 4 Nov 2016 20:48:31 +0000 (15:48 -0500)
commitfd6af2dee8016ac64b3c4943d8ded04767a0a752
treee9e3ca04075823a1fe471c9dddeba85815960c66
parentcb30963d222cb1e12af9bbf8dfed58001c9fcaf4
bridges/bridge_softmix: Remove SSRC changes on join/leave; update video source

WebRTC clients really, really want to know the SSRC of the media they're
getting. Changing the SSRC is generally not a good thing.

bridge_softmix, starting in Asterisk 12, started changing the SSRC of
parties as they joined or left the bridge. With most phones, this isn't
a problem: phones just play back the stream they're getting. With WebRTC
clients, however, the SSRC is tied to a media stream that may be
negotiated. When a new SSRC just shows up, the media can be dropped.

As it turns out, the SSRC change shouldn't even be necessary. From the
perspective of the client, it's still talking to Asterisk with the same
media stream: why indicate that the far party has suddenly changed to a
different source of media?

This patch opts to just remove the SSRC changes. With this patch, video
clients that join/leave a softmix bridge actually get the video stream
instead of freaking out.

ASTERISK-26555

Change-Id: I27fec098b32e7c8718b4b65f3fd5fa73527968bf
bridges/bridge_softmix.c