]> git.ipfire.org Git - thirdparty/asterisk.git/commit
app_dial: Hold reference to calling channel formats when dialing outbound. 69/1569/1
authorJoshua Colp <jcolp@digium.com>
Tue, 23 Jun 2015 16:21:41 +0000 (13:21 -0300)
committerMatt Jordan <mjordan@digium.com>
Wed, 4 Nov 2015 22:13:14 +0000 (17:13 -0500)
commitac9432fdb64cd7fa7d9719760e5f33c93e5a1406
tree2043e707858ae8476120140060f590b89150086c
parent385e26efe24070bfdb654ef5aa44797a290a45d3
app_dial: Hold reference to calling channel formats when dialing outbound.

Currently when requesting a channel the native formats of the
calling channel are provided to the core for usage when dialing
the outbound channel. This occurs without holding the channel lock
or keeping a reference to the formats. This is problematic as
the channel driver may end up changing the formats during this time.
In the case of chan_sip this happens when an SDP negotiation
completes.

This change makes it so app_dial keeps a reference to the native
formats of the calling channel which guarantees that they will
remain valid for the period of time needed.

ASTERISK-25172 #close

Change-Id: I2f0a67bd0d5d14c3bdbaae552b4b1613a283f0db
(cherry picked from commit 3b2b004d699b8cc7b808f62536bb2bc4db8b4e0e)
apps/app_dial.c