]> git.ipfire.org Git - thirdparty/asterisk.git/commit
res_pjsip: Fix statsd regression. 75/3175/1
authorRichard Mudgett <rmudgett@digium.com>
Mon, 11 Jul 2016 15:25:04 +0000 (10:25 -0500)
committerRichard Mudgett <rmudgett@digium.com>
Tue, 12 Jul 2016 16:52:10 +0000 (11:52 -0500)
commit97b4c7a5b42eb84eaeaf9ec3f524de40e1d7fd74
tree88b5f4397b9bc6b9e885a1b0bf0b391aa5b981ec
parent5ee205d8bb0dfbae5be89661aa3a787fbdf9986b
res_pjsip: Fix statsd regression.

The ASTERISK-25904 change-id I8fad8aae9305481469c38d2146e1ba3a56d3108f
patch introduced several regressions when the newly created "Updated"
state goes out for each endpoint registration refresh.

1) It restarted any OPTIONS RTT ping cycle.

2) It would interfere with a currently active ping and throw off that
ping's resulting RTT calculation.

3) It cleared the RTT time each time the endpoint was refreshed.

4) The cleared RTT time was sent out as a statsd update each time.

5) It created two AMI events for each update.

* Revert the original patch and reimplement it.  Now the current contact
status state is re-sent instead of the state being momentarily toggled
every time the endpoint refreshes its registration.  The statsd events are
not created for the re-sent refresh because they are sent after every
OPTIONS ping.

ASTERISK-26160 #close
Reported by: Matt Jordan

Change-Id: Ie072be790fbb2a8f5c1c874266e4143fa31f66d1
CHANGES
include/asterisk/res_pjsip.h
res/res_pjsip/pjsip_configuration.c
res/res_pjsip/pjsip_options.c